In tests check for SIGTERM signal after nvimProcess.kill() #54

angrypie · 2025-02-13T17:07:57Z

Error is not printed before process.exit(1)

Added simple timeout before process.exit(1) to make sure the error is printed before the process exits.
For some reason Nvim process is exiting with code null so check for SIGTERM as well.

Alternatively we could do nvim.call('nvim_exec_lua', ['vim.cmd("quit")']) and check for 0 code.

Before

RUN  v2.1.8 /Users/el/Code/github.com/magenta.nvim

❯ node/tea/view.spec.ts (1)
  ❯ Neovim Plugin Tests (1)
    ⠧ basic rendering & update
file:///Users/el/Code/github.com/magenta.nvim/node_modules/vitest/dist/chunks/execute.2pr0rHgK.js:600
   throw new Error(`process.exit unexpectedly called with "${code}"`);
   ^

Error: process.exit unexpectedly called with "1"
   at process.exit (file:///Users/el/Code/github.com/magenta.nvim/node_modules/vitest/dist/chunks/execute.2pr0rHgK.js:600:11)
   at process.<anonymous> (/Users/el/Code/github.com/magenta.nvim/node/test/preamble.ts:194:13)
   at process.emit (node:events:530:35)
❯ node/tea/view.spec.ts (1)
  ❯ Neovim Plugin Tests (1)
    ⠏ basic rendering & update

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Errors

Vitest caught 1 unhandled error during the test run.
This might cause false positive tests. Resolve unhandled errors to make sure your tests are not affected.

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Error: Worker exited unexpectedly
❯ ChildProcess.<anonymous> node_modules/tinypool/dist/index.js:139:34
❯ ChildProcess.emit node:events:530:35
❯ ChildProcess._handle.onexit node:internal/child_process:293:12

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

Test Files (1)
Tests (1)
Errors 1 error
Start at 17:27:31
Duration 651ms (transform 160ms, setup 0ms, collect 405ms, tests 0ms, environment 0ms, prepare 29ms)

After

RUN  v2.1.8 /Users/el/Code/github.com/magenta.nvim

stderr | node/tea/view.spec.ts
Error: Nvim process exited with code null and signal SIGTERM
    at ChildProcess.<anonymous> (/Users/el/Code/github.com/magenta.nvim/node/test/preamble.ts:42:15)
    at ChildProcess.emit (node:events:518:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)

 ✓ node/tea/view.spec.ts (1)
   ✓ Neovim Plugin Tests (1)
     ✓ basic rendering & update

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  17:32:09
   Duration  725ms (transform 170ms, setup 0ms, collect 465ms, tests 130ms, environment 0ms, prepare 33ms)

Check for exit code as well as signal (SIGTERM)

RUN  v2.1.8 /Users/el/Code/github.com/magenta.nvim

✓ node/tea/view.spec.ts (1)
  ✓ Neovim Plugin Tests (1)
    ✓ basic rendering & update

Test Files  1 passed (1)
     Tests  1 passed (1)
  Start at  18:17:33
  Duration  605ms (transform 163ms, setup 0ms, collect 361ms, tests 127ms, environment 0ms, prepare 29ms)

In tests check for SIGTERM signal after nvimProcess.kill()

4efb33c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In tests check for SIGTERM signal after nvimProcess.kill() #54

In tests check for SIGTERM signal after nvimProcess.kill() #54

angrypie commented Feb 13, 2025 •

edited

Loading

In tests check for SIGTERM signal after nvimProcess.kill() #54

Are you sure you want to change the base?

In tests check for SIGTERM signal after nvimProcess.kill() #54

Conversation

angrypie commented Feb 13, 2025 • edited Loading

Error is not printed before process.exit(1)

Before

After

Check for exit code as well as signal (SIGTERM)

angrypie commented Feb 13, 2025 •

edited

Loading